Commit 8e8dae8e authored May 16, 2023 by Arnd Bergmann Committed by Greg Kroah-Hartman Jul 27, 2023

usb: hide unused usbfs_notify_suspend/resume functions



[ Upstream commit 8e6bd945e6dde64fbc60ec3fe252164493a8d3a2 ]

The declaration is in an #ifdef, which causes warnings when building
with 'make W=1' and without CONFIG_PM:

drivers/usb/core/devio.c:742:6: error: no previous prototype for 'usbfs_notify_suspend'
drivers/usb/core/devio.c:747:6: error: no previous prototype for 'usbfs_notify_resume'

Use the same #ifdef check around the function definitions to avoid
the warnings and slightly shrink the USB core.

Fixes: 7794f486 ("usbfs: Add ioctls for runtime power management")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20230516202103.558301-1-arnd@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fe9cdc19

drivers/usb/core/devio.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -734,6 +734,7 @@ static int driver_resume(struct usb_interface *intf)
		return 0;
		}

		#ifdef CONFIG_PM
		/* The following routines apply to the entire device, not interfaces */
		void usbfs_notify_suspend(struct usb_device *udev)
		{
		@@ -752,6 +753,7 @@ void usbfs_notify_resume(struct usb_device *udev)
		}
		mutex_unlock(&usbfs_mutex);
		}
		#endif

		struct usb_driver usbfs_driver = {
		.name = "usbfs",