Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e8c0386 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Herbert Xu
Browse files

crypto: qat/adf_aer - Replace GFP_ATOMIC with GFP_KERNEL in adf_dev_aer_schedule_reset() 



adf_dev_aer_schedule_reset() is never called in atomic context, as it
calls wait_for_completion_timeout().

adf_dev_aer_schedule_reset() calls kzalloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1c96dde1

drivers/crypto/qat/qat_common/adf_aer.c

+1 −1
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ static int adf_dev_aer_schedule_reset(struct adf_accel_dev *accel_dev, 
		return 0;



	set_bit(ADF_STATUS_RESTARTING, &accel_dev->status);

	reset_data = kzalloc(sizeof(*reset_data), GFP_ATOMIC);

	reset_data = kzalloc(sizeof(*reset_data), GFP_KERNEL);

	if (!reset_data)

		return -ENOMEM;

	reset_data->accel_dev = accel_dev;