Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e717396 authored by Philipp Zabel's avatar Philipp Zabel Committed by Mauro Carvalho Chehab
Browse files

media: coda: split decoder sequence initialization out of start decoding 



The sequence initialization already has to happen during the
initialization phase, after headers have been queued on the OUTPUT
queue. This means that sequence initialization has to be queued as
a work item from QBUF on the OUTPUT queue. The internal framebuffer
setup should be done later during VIDIOC_REQBUFS() on the CAPTURE
queue.

Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 7e5eaae0

drivers/media/platform/coda/coda-bit.c

+26 −4
Original line number Diff line number Diff line
@@ -1661,7 +1661,7 @@ static bool coda_reorder_enable(struct coda_ctx *ctx) 
	return profile > V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE;

}



static int __coda_start_decoding(struct coda_ctx *ctx)

static int __coda_decoder_seq_init(struct coda_ctx *ctx)

{

	struct coda_q_data *q_data_src, *q_data_dst;

	u32 bitstream_buf, bitstream_size;
@@ -1684,8 +1684,6 @@ static int __coda_start_decoding(struct coda_ctx *ctx) 
	src_fourcc = q_data_src->fourcc;

	dst_fourcc = q_data_dst->fourcc;



	coda_write(dev, ctx->parabuf.paddr, CODA_REG_BIT_PARA_BUF_ADDR);



	/* Update coda bitstream read and write pointers from kfifo */

	coda_kfifo_sync_to_device_full(ctx);
@@ -1823,6 +1821,29 @@ static int __coda_start_decoding(struct coda_ctx *ctx) 
			coda_update_profile_level_ctrls(ctx, profile, level);

	}



	return 0;

}



static int __coda_start_decoding(struct coda_ctx *ctx)

{

	struct coda_q_data *q_data_src, *q_data_dst;

	struct coda_dev *dev = ctx->dev;

	u32 src_fourcc, dst_fourcc;

	int ret;



	if (!ctx->initialized) {

		ret = __coda_decoder_seq_init(ctx);

		if (ret < 0)

			return ret;

	}



	q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT);

	q_data_dst = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);

	src_fourcc = q_data_src->fourcc;

	dst_fourcc = q_data_dst->fourcc;



	coda_write(dev, ctx->parabuf.paddr, CODA_REG_BIT_PARA_BUF_ADDR);



	ret = coda_alloc_framebuffers(ctx, q_data_dst, src_fourcc);

	if (ret < 0) {

		v4l2_err(&dev->v4l2_dev, "failed to allocate framebuffers\n");
@@ -1831,7 +1852,8 @@ static int __coda_start_decoding(struct coda_ctx *ctx) 


	/* Tell the decoder how many frame buffers we allocated. */

	coda_write(dev, ctx->num_internal_frames, CODA_CMD_SET_FRAME_BUF_NUM);

	coda_write(dev, width, CODA_CMD_SET_FRAME_BUF_STRIDE);

	coda_write(dev, round_up(q_data_dst->rect.width, 16),

		   CODA_CMD_SET_FRAME_BUF_STRIDE);



	if (dev->devtype->product != CODA_DX6) {

		/* Set secondary AXI IRAM */