Commit 8e485917 authored Jul 31, 2007 by Matthias Kaehlcke Committed by Linus Torvalds Jul 31, 2007

Videopix Frame Grabber: Fix unreleased lock in vfc_debug()



Videopix Frame Grabber: vfc_debug() doesn't release the device lock
when copy_from_user() fails

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Acked-by: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0af1a450

drivers/sbus/char/vfc_dev.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -248,6 +248,7 @@ static int vfc_debug(struct vfc_dev dev, int cmd, void __user argp)
	buffer,inout.len);		buffer,inout.len);

	if (copy_to_user(argp,&inout,sizeof(inout))) {		if (copy_to_user(argp,&inout,sizeof(inout))) {
			vfc_unlock_device(dev);
	kfree(buffer);		kfree(buffer);
	return -EFAULT;		return -EFAULT;
	}		}