Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e1b6d96 authored by Srinivas Neeli's avatar Srinivas Neeli Committed by Greg Kroah-Hartman
Browse files

gpio: zynq: Check return value of pm_runtime_get_sync 



[ Upstream commit a51b2fb94b04ab71e53a71b9fad03fa826941254 ]

Return value of "pm_runtime_get_sync" API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any warning.

Addresses-Coverity: "check_return"
Signed-off-by: default avatarSrinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b1122080

drivers/gpio/gpio-zynq.c

+4 −1
Original line number Diff line number Diff line
@@ -938,8 +938,11 @@ static int zynq_gpio_probe(struct platform_device *pdev) 
static int zynq_gpio_remove(struct platform_device *pdev)

{

	struct zynq_gpio *gpio = platform_get_drvdata(pdev);

	int ret;



	pm_runtime_get_sync(&pdev->dev);

	ret = pm_runtime_get_sync(&pdev->dev);

	if (ret < 0)

		dev_warn(&pdev->dev, "pm_runtime_get_sync() Failed\n");

	gpiochip_remove(&gpio->chip);

	clk_disable_unprepare(gpio->clk);

	device_set_wakeup_capable(&pdev->dev, 0);