Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e03f26b authored by Jacob Keller's avatar Jacob Keller Committed by Jeff Kirsher
Browse files

fm10k: reduce the scope of the result local variable 



Reduce the scope of the result local variable in the
fm10k_iov_msg_lport_state_pf function.

This was detected by cppcheck and resolves the following warning
produced by that tool:

[fm10k_pf.c:1435]: (style) The scope of the variable 'result' can be
reduced.

Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 71974d7e

drivers/net/ethernet/intel/fm10k/fm10k_pf.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -1352,7 +1352,6 @@ s32 fm10k_iov_msg_lport_state_pf(struct fm10k_hw *hw, u32 **results, 
				 struct fm10k_mbx_info *mbx)

				 struct fm10k_mbx_info *mbx)

{

{

	struct fm10k_vf_info *vf_info = (struct fm10k_vf_info *)mbx;

	struct fm10k_vf_info *vf_info = (struct fm10k_vf_info *)mbx;

	u32 *result;

	s32 err = 0;

	s32 err = 0;

	u32 msg[2];

	u32 msg[2];

	u8 mode = 0;

	u8 mode = 0;
@@ -1362,7 +1361,7 @@ s32 fm10k_iov_msg_lport_state_pf(struct fm10k_hw *hw, u32 **results, 
		return FM10K_ERR_PARAM;

		return FM10K_ERR_PARAM;





	if (!!results[FM10K_LPORT_STATE_MSG_XCAST_MODE]) {

	if (!!results[FM10K_LPORT_STATE_MSG_XCAST_MODE]) {

		result = results[FM10K_LPORT_STATE_MSG_XCAST_MODE];

		u32 *result = results[FM10K_LPORT_STATE_MSG_XCAST_MODE];





		/* XCAST mode update requested */

		/* XCAST mode update requested */

		err = fm10k_tlv_attr_get_u8(result, &mode);

		err = fm10k_tlv_attr_get_u8(result, &mode);