Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8deaaf4b authored by Olivier Maignial's avatar Olivier Maignial Committed by Greg Kroah-Hartman
Browse files

mtd: spinand: toshiba: Fix ecc_get_status 

commit 8544cda94dae6be3f1359539079c68bb731428b1 upstream.

Reading ECC status is failing.

tx58cxgxsxraix_ecc_get_status() is using on-stack buffer
for SPINAND_GET_FEATURE_OP() output. It is not suitable
for DMA needs of spi-mem.

Fix this by using the spi-mem operations dedicated buffer
spinand->scratchbuf.

See
spinand->scratchbuf:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/mtd/spinand.h?h=v6.3#n418
spi_mem_check_op():
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-mem.c?h=v6.3#n199



Fixes: 10949af1 ("mtd: spinand: Add initial support for Toshiba TC58CVG2S0H")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarOlivier Maignial <olivier.maignial@hotmail.fr>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/DB4P250MB1032553D05FBE36DEE0D311EFE23A@DB4P250MB1032.EURP250.PROD.OUTLOOK.COM


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eacb19bd

drivers/mtd/nand/spi/toshiba.c

+2 −2
Original line number Diff line number Diff line
@@ -60,7 +60,7 @@ static int tc58cxgxsx_ecc_get_status(struct spinand_device *spinand, 
{

	struct nand_device *nand = spinand_to_nand(spinand);

	u8 mbf = 0;

	struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, &mbf);

	struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, spinand->scratchbuf);



	switch (status & STATUS_ECC_MASK) {

	case STATUS_ECC_NO_BITFLIPS:
@@ -79,7 +79,7 @@ static int tc58cxgxsx_ecc_get_status(struct spinand_device *spinand, 
		if (spi_mem_exec_op(spinand->spimem, &op))

			return nand->eccreq.strength;



		mbf >>= 4;

		mbf = *(spinand->scratchbuf) >> 4;



		if (WARN_ON(mbf > nand->eccreq.strength || !mbf))

			return nand->eccreq.strength;