Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8dd29f19 authored by Guenter Roeck's avatar Guenter Roeck Committed by Wim Van Sebroeck
Browse files

watchdog: rtd119x_wdt: Fix remove function 



The driver registers the watchdog with devm_watchdog_register_device() but
still calls watchdog_unregister_device() on remove. Since clocks have to
be stopped when removing the driver, after the watchdog device has been
unregistered, we can not drop the call to watchdog_unregister_device().
Use watchdog_register_device() to register the watchdog.

Fixes: 2bdf6acb ("watchdog: Add Realtek RTD1295")
Cc: Andreas Färber <afaerber@suse.de>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent e2a4aeda

drivers/watchdog/rtd119x_wdt.c

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static int rtd119x_wdt_probe(struct platform_device *pdev) 
	rtd119x_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout);

	rtd119x_wdt_stop(&data->wdt_dev);



	ret = devm_watchdog_register_device(&pdev->dev, &data->wdt_dev);

	ret = watchdog_register_device(&data->wdt_dev);

	if (ret) {

		clk_disable_unprepare(data->clk);

		clk_put(data->clk);