Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d8b83f5 authored by Quinn Tran's avatar Quinn Tran Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix partial flash write of MBI 

For new adapters with multiple flash regions to write to, current code
allows FW & Boot regions to be written, while other regions are blocked via
sysfs. The fix is to block all flash read/write through sysfs interface.

Fixes: e81d1bcb ("scsi: qla2xxx: Further limit FLASH region write access from SysFS")
Cc: stable@vger.kernel.org # 5.2
Link: https://lore.kernel.org/r/20191022193643.7076-3-hmadhani@marvell.com


Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
Signed-off-by: default avatarGirish Basrur <gbasrur@marvell.com>
Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c2ff2a36

drivers/scsi/qla2xxx/qla_attr.c

+3 −4
Original line number Diff line number Diff line
@@ -440,9 +440,6 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj, 
		valid = 0;

		if (ha->optrom_size == OPTROM_SIZE_2300 && start == 0)

			valid = 1;

		else if (start == (ha->flt_region_boot * 4) ||

		    start == (ha->flt_region_fw * 4))

			valid = 1;

		else if (IS_QLA24XX_TYPE(ha) || IS_QLA25XX(ha))

			valid = 1;

		if (!valid) {
@@ -489,8 +486,10 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj, 
		    "Writing flash region -- 0x%x/0x%x.\n",

		    ha->optrom_region_start, ha->optrom_region_size);



		ha->isp_ops->write_optrom(vha, ha->optrom_buffer,

		rval = ha->isp_ops->write_optrom(vha, ha->optrom_buffer,

		    ha->optrom_region_start, ha->optrom_region_size);

		if (rval)

			rval = -EIO;

		break;

	default:

		rval = -EINVAL;