Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d884c08 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions 



[ Upstream commit fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b ]

of_find_node_by_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: e3825ba1 ("irqchip/gic-v3: Add support for partitioned PPIs")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-6-linmq006@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 58e67c81

drivers/irqchip/irq-gic-v3.c

+4 −1
Original line number Diff line number Diff line
@@ -1657,12 +1657,15 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) 
				continue;



			cpu = of_cpu_node_to_id(cpu_node);

			if (WARN_ON(cpu < 0))

			if (WARN_ON(cpu < 0)) {

				of_node_put(cpu_node);

				continue;

			}



			pr_cont("%pOF[%d] ", cpu_node, cpu);



			cpumask_set_cpu(cpu, &part->mask);

			of_node_put(cpu_node);

		}



		pr_cont("}\n");