Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d080236 authored by Bart Van Assche's avatar Bart Van Assche Committed by Robert Love
Browse files

libfc: Clarify fc_exch_find() 



The condition ep != NULL && ep->xid != xid can never be met. Make
this explicit.

Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Cc: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
parent a84ea8c7

drivers/scsi/libfc/fc_exch.c

+3 −1
Original line number Diff line number Diff line
@@ -836,8 +836,10 @@ static struct fc_exch *fc_exch_find(struct fc_exch_mgr *mp, u16 xid) 
		pool = per_cpu_ptr(mp->pool, xid & fc_cpu_mask);

		spin_lock_bh(&pool->lock);

		ep = fc_exch_ptr_get(pool, (xid - mp->min_xid) >> fc_cpu_order);

		if (ep && ep->xid == xid)

		if (ep) {

			WARN_ON(ep->xid != xid);

			fc_exch_hold(ep);

		}

		spin_unlock_bh(&pool->lock);

	}

	return ep;