Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cff599e authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

qed: avoid truncating work queue length 



[ Upstream commit 954fd908f177604d4cce77e2a88cc50b29bad5ff ]

clang complains that the temporary string for the name passed into
alloc_workqueue() is too short for its contents:

drivers/net/ethernet/qlogic/qed/qed_main.c:1218:3: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 18 [-Werror,-Wformat-truncation]

There is no need for a temporary buffer, and the actual name of a workqueue
is 32 bytes (WQ_NAME_LEN), so just use the interface as intended to avoid
the truncation.

Fixes: 59ccf86f ("qed: Add driver infrastucture for handling mfw requests.")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240326223825.4084412-4-arnd@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6dde0c15

drivers/net/ethernet/qlogic/qed/qed_main.c

+4 −5
Original line number Diff line number Diff line
@@ -1177,7 +1177,6 @@ static void qed_slowpath_task(struct work_struct *work) 
static int qed_slowpath_wq_start(struct qed_dev *cdev)

{

	struct qed_hwfn *hwfn;

	char name[NAME_SIZE];

	int i;



	if (IS_VF(cdev))
@@ -1186,11 +1185,11 @@ static int qed_slowpath_wq_start(struct qed_dev *cdev) 
	for_each_hwfn(cdev, i) {

		hwfn = &cdev->hwfns[i];



		snprintf(name, NAME_SIZE, "slowpath-%02x:%02x.%02x",

			 cdev->pdev->bus->number,

			 PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id);

		hwfn->slowpath_wq = alloc_workqueue("slowpath-%02x:%02x.%02x",

					 0, 0, cdev->pdev->bus->number,

					 PCI_SLOT(cdev->pdev->devfn),

					 hwfn->abs_pf_id);



		hwfn->slowpath_wq = alloc_workqueue(name, 0, 0);

		if (!hwfn->slowpath_wq) {

			DP_NOTICE(hwfn, "Cannot create slowpath workqueue\n");

			return -ENOMEM;