Commit 8cbe9b76 authored Aug 17, 2020 by Rob Clark Committed by Greg Kroah-Hartman Sep 17, 2020

drm/msm/gpu: make ringbuffer readonly



[ Upstream commit 352c83fb39cae3eff95a8e1ed23006291abb6196 ]

The GPU has no business writing into the ringbuffer, let's make it
readonly to the GPU.

Fixes: 7198e6b0 ("drm/msm: add a3xx gpu support")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ebd9aff7

drivers/gpu/drm/msm/msm_ringbuffer.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -27,7 +27,8 @@ struct msm_ringbuffer msm_ringbuffer_new(struct msm_gpu gpu, int id,
		ring->id = id;

		ring->start = msm_gem_kernel_new(gpu->dev, MSM_GPU_RINGBUFFER_SZ,
		MSM_BO_WC, gpu->aspace, &ring->bo, &ring->iova);
		MSM_BO_WC \| MSM_BO_GPU_READONLY, gpu->aspace, &ring->bo,
		&ring->iova);

		if (IS_ERR(ring->start)) {
		ret = PTR_ERR(ring->start);