Commit 8c60d12b authored Sep 04, 2025 by Stefan Wahren Committed by Greg Kroah-Hartman Oct 02, 2025

net: fec: Fix possible NPD in fec_enet_phy_reset_after_clk_enable()



[ Upstream commit 03e79de4608bdd48ad6eec272e196124cefaf798 ]

The function of_phy_find_device may return NULL, so we need to take
care before dereferencing phy_dev.

Fixes: 64a632da538a ("net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Richard Leitner <richard.leitner@skidata.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Wei Fang <wei.fang@nxp.com>
Link: https://patch.msgid.link/20250904091334.53965-1-wahrenst@gmx.net


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2f28d51c

drivers/net/ethernet/freescale/fec_main.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2018,6 +2018,7 @@ static void fec_enet_phy_reset_after_clk_enable(struct net_device *ndev)
		*/
		phy_dev = of_phy_find_device(fep->phy_node);
		phy_reset_after_clk_enable(phy_dev);
		if (phy_dev)
		put_device(&phy_dev->mdio.dev);
		}
		}