Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c3653c4 authored by Pietro Borrello's avatar Pietro Borrello Committed by Greg Kroah-Hartman
Browse files

HID: check empty report_list in bigben_probe() 



[ Upstream commit c7bf714f875531f227f2ef1fdcc8f4d44e7c7d9d ]

Add a check for empty report_list in bigben_probe().
The missing check causes a type confusion when issuing a list_entry()
on an empty report_list.
The problem is caused by the assumption that the device must
have valid report_list. While this will be true for all normal HID
devices, a suitably malicious device can violate the assumption.

Fixes: 256a90ed ("HID: hid-bigbenff: driver for BigBen Interactive PS3OFMINIPAD gamepad")
Signed-off-by: default avatarPietro Borrello <borrello@diag.uniroma1.it>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 89e7fe39

drivers/hid/hid-bigbenff.c

+5 −0
Original line number Diff line number Diff line
@@ -344,6 +344,11 @@ static int bigben_probe(struct hid_device *hid, 
	}



	report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list;

	if (list_empty(report_list)) {

		hid_err(hid, "no output report found\n");

		error = -ENODEV;

		goto error_hw_stop;

	}

	bigben->report = list_entry(report_list->next,

		struct hid_report, list);