Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c015cd5 authored by Zheng Yongjun's avatar Zheng Yongjun Committed by Greg Kroah-Hartman
Browse files

Input: stmfts - fix reference leak in stmfts_input_open 



[ Upstream commit 26623eea0da3476446909af96c980768df07bbd9 ]

pm_runtime_get_sync() will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put_noidle will result
in reference leak in stmfts_input_open, so we should fix it.

Signed-off-by: default avatarZheng Yongjun <zhengyongjun3@huawei.com>
Link: https://lore.kernel.org/r/20220317131604.53538-1-zhengyongjun3@huawei.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent bb83a744

drivers/input/touchscreen/stmfts.c

+5 −3
Original line number Original line Diff line number Diff line
@@ -339,11 +339,11 @@ static int stmfts_input_open(struct input_dev *dev) 




	err = pm_runtime_get_sync(&sdata->client->dev);

	err = pm_runtime_get_sync(&sdata->client->dev);

	if (err < 0)

	if (err < 0)

		return err;

		goto out;





	err = i2c_smbus_write_byte(sdata->client, STMFTS_MS_MT_SENSE_ON);

	err = i2c_smbus_write_byte(sdata->client, STMFTS_MS_MT_SENSE_ON);

	if (err)

	if (err)

		return err;

		goto out;





	mutex_lock(&sdata->mutex);

	mutex_lock(&sdata->mutex);

	sdata->running = true;

	sdata->running = true;
@@ -366,7 +366,9 @@ static int stmfts_input_open(struct input_dev *dev) 
				 "failed to enable touchkey\n");

				 "failed to enable touchkey\n");

	}

	}





	return 0;

out:

	pm_runtime_put_noidle(&sdata->client->dev);

	return err;

}

}





static void stmfts_input_close(struct input_dev *dev)

static void stmfts_input_close(struct input_dev *dev)