Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8bdda5dd authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by David S. Miller
Browse files

atm: horizon: Remove some unused functions 



Removes some functions that are not used anywhere:
channel_to_vpivci() query_tx_channel_config() rx_disabled_handler()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 927a97cc

drivers/atm/horizon.c

+0 −24
Original line number Diff line number Diff line
@@ -458,12 +458,6 @@ static inline void update_tx_channel_config (hrz_dev * dev, short chan, u8 mode, 
    return;

}



static inline u16 query_tx_channel_config (hrz_dev * dev, short chan, u8 mode) {

  wr_regw (dev, TX_CHANNEL_CONFIG_COMMAND_OFF,

	   chan * TX_CHANNEL_CONFIG_MULT | mode);

    return rd_regw (dev, TX_CHANNEL_CONFIG_DATA_OFF);

}



/********** dump functions **********/



static inline void dump_skb (char * prefix, unsigned int vc, struct sk_buff * skb) {
@@ -513,16 +507,6 @@ static inline void dump_framer (hrz_dev * dev) { 


/* RX channels are 10 bit integers, these fns are quite paranoid */



static inline int channel_to_vpivci (const u16 channel, short * vpi, int * vci) {

  unsigned short vci_bits = 10 - vpi_bits;

  if ((channel & RX_CHANNEL_MASK) == channel) {

    *vci = channel & ((~0)<<vci_bits);

    *vpi = channel >> vci_bits;

    return channel ? 0 : -EINVAL;

  }

  return -EINVAL;

}



static inline int vpivci_to_channel (u16 * channel, const short vpi, const int vci) {

  unsigned short vci_bits = 10 - vpi_bits;

  if (0 <= vpi && vpi < 1<<vpi_bits && 0 <= vci && vci < 1<<vci_bits) {
@@ -1260,14 +1244,6 @@ static u32 rx_queue_entry_next (hrz_dev * dev) { 
  return rx_queue_entry;

}



/********** handle RX disabled by device **********/



static inline void rx_disabled_handler (hrz_dev * dev) {

  wr_regw (dev, RX_CONFIG_OFF, rd_regw (dev, RX_CONFIG_OFF) | RX_ENABLE);

  // count me please

  PRINTK (KERN_WARNING, "RX was disabled!");

}



/********** handle RX data received by device **********/



// called from IRQ handler