Commit 8ba0ddd0 authored Jan 20, 2019 by Jason Gunthorpe

RDMA/iw_cxgb4: Drop __GFP_NOFAIL



There is no reason for this __GFP_NOFAIL, none of the other routines in
this file use it, and there is an error unwind here. NOFAIL should be
reserved for special cases, not used by network drivers.

Fixes: 6a0b6174 ("rdma/cxgb4: Add support for kernel mode SRQ's")
Reported-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 0a353c2e

drivers/infiniband/hw/cxgb4/qp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2597,7 +2597,7 @@ static int alloc_srq_queue(struct c4iw_srq srq, struct c4iw_dev_ucontext uctx,
		/* build fw_ri_res_wr */
		wr_len = sizeof(res_wr) + sizeof(res);

		skb = alloc_skb(wr_len, GFP_KERNEL \| __GFP_NOFAIL);
		skb = alloc_skb(wr_len, GFP_KERNEL);
		if (!skb)
		goto err_free_queue;
		set_wr_txq(skb, CPL_PRIORITY_CONTROL, 0);