Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b294504 authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio: siox: Use devm_ managed gpiochip 



By using devm_gpiochip_add_data() we can get rid of the
remove() callback. As this driver doesn't use the
gpiochip data pointer we simply pass in NULL.

Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent acc14137

drivers/gpio/gpio-siox.c

+1 −10
Original line number Diff line number Diff line
@@ -246,24 +246,15 @@ static int gpio_siox_probe(struct siox_device *sdevice) 
	girq->default_type = IRQ_TYPE_NONE;

	girq->handler = handle_level_irq;



	ret = gpiochip_add(&ddata->gchip);

	ret = devm_gpiochip_add_data(dev, &ddata->gchip, NULL);

	if (ret)

		dev_err(dev, "Failed to register gpio chip (%d)\n", ret);



	return ret;

}



static int gpio_siox_remove(struct siox_device *sdevice)

{

	struct gpio_siox_ddata *ddata = dev_get_drvdata(&sdevice->dev);



	gpiochip_remove(&ddata->gchip);

	return 0;

}



static struct siox_driver gpio_siox_driver = {

	.probe = gpio_siox_probe,

	.remove = gpio_siox_remove,

	.set_data = gpio_siox_set_data,

	.get_data = gpio_siox_get_data,

	.driver = {