Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ae598d0 authored Dec 21, 2010 by Dan Carpenter Committed by James Bottomley Dec 23, 2010

[SCSI] qla2xxx: list cursors are not null



This is just a cleanup.

The unneeded NULL check annoys static checkers because we already
derefenced it and the we check it and then (if it's not the _safe()
version) we dereference it again without checking.  And the static
checker is all, "Wah?  Is it null or not?"

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Madhuranath Iyengar <Madhu.Iyengar@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent 579d12b5

drivers/scsi/qla2xxx/qla_init.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3888,7 +3888,7 @@ qla2x00_update_fcports(scsi_qla_host_t *base_vha)
		list_for_each_entry(vha, &base_vha->hw->vp_list, list) {
		atomic_inc(&vha->vref_count);
		list_for_each_entry(fcport, &vha->vp_fcports, list) {
		if (fcport && fcport->drport &&
		if (fcport->drport &&
		atomic_read(&fcport->state) != FCS_UNCONFIGURED) {
		spin_unlock_irqrestore(&ha->vport_slock, flags);

drivers/scsi/qla2xxx/qla_os.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2371,7 +2371,7 @@ qla2x00_remove_one(struct pci_dev *pdev)
		list_for_each_entry(vha, &ha->vp_list, list) {
		atomic_inc(&vha->vref_count);

		if (vha && vha->fc_vport) {
		if (vha->fc_vport) {
		spin_unlock_irqrestore(&ha->vport_slock, flags);

		fc_vport_terminate(vha->fc_vport);