Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ad94021 authored by Stephen Rothwell's avatar Stephen Rothwell Committed by Michael Ellerman
Browse files

powerpc: annotate implicit fall throughs 



There is a plan to build the kernel with -Wimplicit-fallthrough and these
places in the code produced warnings, but because we build arch/powerpc
with -Werror, they became errors.  Fix them up.

This patch produces no change in behaviour, but should be reviewed in
case these are actually bugs not intentional fallthoughs.

Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent f91203e7

arch/powerpc/kernel/nvram_64.c

+1 −0
Original line number Diff line number Diff line
@@ -809,6 +809,7 @@ static long dev_nvram_ioctl(struct file *file, unsigned int cmd, 
#ifdef CONFIG_PPC_PMAC

	case OBSOLETE_PMAC_NVRAM_GET_OFFSET:

		printk(KERN_WARNING "nvram: Using obsolete PMAC_NVRAM_GET_OFFSET ioctl\n");

		/* fall through */

	case IOC_NVRAM_GET_OFFSET: {

		int part, offset;

arch/powerpc/platforms/powermac/feature.c

+1 −0
Original line number Diff line number Diff line
@@ -1471,6 +1471,7 @@ static long g5_i2s_enable(struct device_node *node, long param, long value) 
	case 2:

		if (macio->type == macio_shasta)

			break;

		/* fall through */

	default:

		return -ENODEV;

	}

arch/powerpc/xmon/xmon.c

+1 −0
Original line number Diff line number Diff line
@@ -4043,6 +4043,7 @@ static int do_spu_cmd(void) 
		subcmd = inchar();

		if (isxdigit(subcmd) || subcmd == '\n')

			termch = subcmd;

		/* fall through */

	case 'f':

		scanhex(&num);

		if (num >= XMON_NUM_SPUS || !spu_info[num].spu) {