Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ac6d452 authored by Ursula Braun's avatar Ursula Braun Committed by David S. Miller
Browse files

ctcm: avoid crash in ctcm_remove_device 



Channels are already removed when setting a ctcm-device offline.
Thus ctcm_remove_device must not refer to channel information.
Solution: delete channel information from the trace call in
ctcm_remove_device.

Signed-off-by: default avatarUrsula Braun <ursula.braun@de.ibm.com>
Signed-off-by: default avatarFrank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f2148565

drivers/s390/net/ctcm_main.c

+2 −4
Original line number Diff line number Diff line
@@ -1677,10 +1677,8 @@ static void ctcm_remove_device(struct ccwgroup_device *cgdev) 
	BUG_ON(priv == NULL);



	CTCM_DBF_TEXT_(SETUP, CTC_DBF_INFO,

			"removing device %s, r/w = %s/%s, proto : %d",

			priv->channel[READ]->netdev->name,

			priv->channel[READ]->id, priv->channel[WRITE]->id,

			priv->protocol);

			"removing device %p, proto : %d",

			cgdev, priv->protocol);



	if (cgdev->state == CCWGROUP_ONLINE)

		ctcm_shutdown_device(cgdev);