Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ab18d71 authored by Jorgen Hansen's avatar Jorgen Hansen Committed by David S. Miller
Browse files

VSOCK: Detach QP check should filter out non matching QPs. 



The check in vmci_transport_peer_detach_cb should only allow a
detach when the qp handle of the transport matches the one in
the detach message.

Testing: Before this change, a detach from a peer on a different
socket would cause an active stream socket to register a detach.

Reviewed-by: default avatarGeorge Zhang <georgezhang@vmware.com>
Signed-off-by: default avatarJorgen Hansen <jhansen@vmware.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 52f95bbf

net/vmw_vsock/vmci_transport.c

+2 −2
Original line number Diff line number Diff line
@@ -842,7 +842,7 @@ static void vmci_transport_peer_detach_cb(u32 sub_id, 
	 * qp_handle.

	 */

	if (vmci_handle_is_invalid(e_payload->handle) ||

	    vmci_handle_is_equal(trans->qp_handle, e_payload->handle))

	    !vmci_handle_is_equal(trans->qp_handle, e_payload->handle))

		return;



	/* We don't ask for delayed CBs when we subscribe to this event (we
@@ -2154,7 +2154,7 @@ module_exit(vmci_transport_exit); 


MODULE_AUTHOR("VMware, Inc.");

MODULE_DESCRIPTION("VMCI transport for Virtual Sockets");

MODULE_VERSION("1.0.2.0-k");

MODULE_VERSION("1.0.3.0-k");

MODULE_LICENSE("GPL v2");

MODULE_ALIAS("vmware_vsock");

MODULE_ALIAS_NETPROTO(PF_VSOCK);