Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a9a654b authored by Jian Shen's avatar Jian Shen Committed by David S. Miller
Browse files

net: hns3: fix sparse: warning when calling hclge_set_vlan_filter_hw() 



The input parameter "proto" in function hclge_set_vlan_filter_hw()
is asked to be __be16, but got u16 when calling it in function
hclge_update_port_base_vlan_cfg().

This patch fixes it by converting it with htons().

Reported-by: default avatarkbuild test robot <lkp@intel.com>
Fixes: 21e043cd ("net: hns3: fix set port based VLAN for PF")
Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7cf89b5

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+4 −2
Original line number Diff line number Diff line
@@ -6964,7 +6964,8 @@ int hclge_update_port_base_vlan_cfg(struct hclge_vport *vport, u16 state, 


	if (state == HNAE3_PORT_BASE_VLAN_MODIFY) {

		/* add new VLAN tag */

		ret = hclge_set_vlan_filter_hw(hdev, vlan_info->vlan_proto,

		ret = hclge_set_vlan_filter_hw(hdev,

					       htons(vlan_info->vlan_proto),

					       vport->vport_id,

					       vlan_info->vlan_tag,

					       vlan_info->qos, false);
@@ -6972,7 +6973,8 @@ int hclge_update_port_base_vlan_cfg(struct hclge_vport *vport, u16 state, 
			return ret;



		/* remove old VLAN tag */

		ret = hclge_set_vlan_filter_hw(hdev, old_vlan_info->vlan_proto,

		ret = hclge_set_vlan_filter_hw(hdev,

					       htons(old_vlan_info->vlan_proto),

					       vport->vport_id,

					       old_vlan_info->vlan_tag,

					       old_vlan_info->qos, true);