Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89f3e4a5 authored by Preethi Banala's avatar Preethi Banala Committed by Jeff Kirsher
Browse files

ice: Do not bail out when filter already exists 



If filter already exists, do not go through error path flow but instead
continue to process rest of the function. Hence have an appropriate check
after adding MAC filters.

Signed-off-by: default avatarPreethi Banala <preethi.banala@intel.com>
Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 4e1af7bf

drivers/net/ethernet/intel/ice/ice_main.c

+5 −1
Original line number Diff line number Diff line
@@ -260,7 +260,11 @@ static int ice_vsi_sync_fltr(struct ice_vsi *vsi) 
	/* Add mac addresses in the sync list */

	status = ice_add_mac(hw, &vsi->tmp_sync_list);

	ice_free_fltr_list(dev, &vsi->tmp_sync_list);

	if (status) {

	/* If filter is added successfully or already exists, do not go into

	 * 'if' condition and report it as error. Instead continue processing

	 * rest of the function.

	 */

	if (status && status != ICE_ERR_ALREADY_EXISTS) {

		netdev_err(netdev, "Failed to add MAC filters\n");

		/* If there is no more space for new umac filters, vsi

		 * should go into promiscuous mode. There should be some