Commit 89dc0be6 authored May 27, 2010 by Julia Lawall Committed by David S. Miller May 28, 2010

drivers/net/hamradio: Eliminate a NULL pointer dereference

At the point of the print, dev is NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 84e5b9f7

drivers/net/hamradio/yam.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1151,8 +1151,7 @@ static int __init yam_init_driver(void)
		dev = alloc_netdev(sizeof(struct yam_port), name,
		yam_setup);
		if (!dev) {
		printk(KERN_ERR "yam: cannot allocate net device %s\n",
		dev->name);
		pr_err("yam: cannot allocate net device\n");
		err = -ENOMEM;
		goto error;
		}