Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89533373 authored by Richard Henderson's avatar Richard Henderson Committed by Greg Kroah-Hartman
Browse files

linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check 



commit 904caa6413c87aacbf7d0682da617c39ca18cf1a upstream.

We must not use the pointer output without validating the
success of the random read.

Reviewed-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarRichard Henderson <rth@twiddle.net>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20200110145422.49141-7-broonie@kernel.org


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0222f9f1

include/linux/random.h

+4 −4
Original line number Diff line number Diff line
@@ -118,19 +118,19 @@ unsigned long randomize_page(unsigned long start, unsigned long range); 
#ifdef CONFIG_ARCH_RANDOM

# include <asm/archrandom.h>

#else

static inline bool arch_get_random_long(unsigned long *v)

static inline bool __must_check arch_get_random_long(unsigned long *v)

{

	return false;

}

static inline bool arch_get_random_int(unsigned int *v)

static inline bool __must_check arch_get_random_int(unsigned int *v)

{

	return false;

}

static inline bool arch_get_random_seed_long(unsigned long *v)

static inline bool __must_check arch_get_random_seed_long(unsigned long *v)

{

	return false;

}

static inline bool arch_get_random_seed_int(unsigned int *v)

static inline bool __must_check arch_get_random_seed_int(unsigned int *v)

{

	return false;

}