Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89468071 authored by Al Viro's avatar Al Viro
Browse files

Simplify devpts_get_sb() failure exits 



postpone simple_set_mnt() until we know we won't fail.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent a135aa2c

fs/devpts/inode.c

+3 −6
Original line number Diff line number Diff line
@@ -384,18 +384,15 @@ static int devpts_get_sb(struct file_system_type *fs_type, 
		s->s_flags |= MS_ACTIVE;

	}



	simple_set_mnt(mnt, s);



	memcpy(&(DEVPTS_SB(s))->mount_opts, &opts, sizeof(opts));



	error = mknod_ptmx(s);

	if (error)

		goto out_dput;

		goto out_undo_sget;



	return 0;

	simple_set_mnt(mnt, s);



out_dput:

	dput(s->s_root); /* undo dget() in simple_set_mnt() */

	return 0;



out_undo_sget:

	deactivate_locked_super(s);