Commit 893626d6 authored Sep 28, 2018 by David Ahern Committed by David S. Miller Oct 01, 2018

rtnetlink: Fail dump if target netnsid is invalid



Link dumps can return results from a target namespace. If the namespace id
is invalid, then the dump request should fail if get_target_net fails
rather than continuing with a dump of the current namespace.

Fixes: 79e1ad14 ("rtnetlink: use netnsid to query interface")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7f6d6558

net/core/rtnetlink.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1898,10 +1898,8 @@ static int rtnl_dump_ifinfo(struct sk_buff skb, struct netlink_callback cb)
		if (tb[IFLA_IF_NETNSID]) {
		netnsid = nla_get_s32(tb[IFLA_IF_NETNSID]);
		tgt_net = get_target_net(skb->sk, netnsid);
		if (IS_ERR(tgt_net)) {
		tgt_net = net;
		netnsid = -1;
		}
		if (IS_ERR(tgt_net))
		return PTR_ERR(tgt_net);
		}

		if (tb[IFLA_EXT_MASK])