Commit 8901896f authored Jul 01, 2020 by Aya Levin Committed by Greg Kroah-Hartman Aug 05, 2020

net/mlx5e: Fix error path of device attach



[ Upstream commit 5cd39b6e9a420329a9a408894be7ba8aa7dd755e ]

On failure to attach the netdev, fix the rollback by re-setting the
device's state back to MLX5E_STATE_DESTROYING.

Failing to attach doesn't stop statistics polling via .ndo_get_stats64.
In this case, although the device is not attached, it falsely continues
to query the firmware for counters. Setting the device's state back to
MLX5E_STATE_DESTROYING prevents the firmware counters query.

Fixes: 26e59d80 ("net/mlx5e: Implement mlx5e interface attach/detach callbacks")
Signed-off-by: Aya Levin <ayal@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 00bedd73

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -5356,6 +5356,8 @@ int mlx5e_attach_netdev(struct mlx5e_priv *priv)
		profile->cleanup_tx(priv);

		out:
		set_bit(MLX5E_STATE_DESTROYING, &priv->state);
		cancel_work_sync(&priv->update_stats_work);
		return err;
		}