Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88f8a5e3 authored by Kulikov Vasiliy's avatar Kulikov Vasiliy Committed by David S. Miller
Browse files

net: tipc: fix information leak to userland 



Structure sockaddr_tipc is copied to userland with padding bytes after
"id" field in union field "name" unitialized.  It leads to leaking of
contents of kernel stack memory.  We have to initialize them to zero.

Signed-off-by: default avatarVasiliy Kulikov <segooon@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ea80907f

net/tipc/socket.c

+1 −0
Original line number Diff line number Diff line
@@ -396,6 +396,7 @@ static int get_name(struct socket *sock, struct sockaddr *uaddr, 
	struct sockaddr_tipc *addr = (struct sockaddr_tipc *)uaddr;

	struct tipc_sock *tsock = tipc_sk(sock->sk);



	memset(addr, 0, sizeof(*addr));

	if (peer) {

		if ((sock->state != SS_CONNECTED) &&

			((peer != 2) || (sock->state != SS_DISCONNECTING)))