Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88de869b authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Doug Ledford
Browse files

RDMA/uverbs: Ensure validity of current QP state value 



The QP state is internal enum which is checked at the driver
level by calling to ib_modify_qp_is_ok(). Move this check closer
to user and leave kernel users to be checked by compiler.

Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 75a45982

drivers/infiniband/core/uverbs_cmd.c

+7 −0
Original line number Diff line number Diff line
@@ -1991,6 +1991,13 @@ static int modify_qp(struct ib_uverbs_file *file, 
		goto release_qp;

	}



	if ((cmd->base.attr_mask & IB_QP_CUR_STATE &&

	    cmd->base.cur_qp_state > IB_QPS_ERR) ||

	    cmd->base.qp_state > IB_QPS_ERR) {

		ret = -EINVAL;

		goto release_qp;

	}



	attr->qp_state		  = cmd->base.qp_state;

	attr->cur_qp_state	  = cmd->base.cur_qp_state;

	attr->path_mtu		  = cmd->base.path_mtu;