Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88d6272a authored by Heiner Kallweit's avatar Heiner Kallweit Committed by David S. Miller
Browse files

net: phy: avoid unneeded MDIO reads in genphy_read_status 



Considering that in polling mode each link drop will be latched,
settings can't have changed if link was up and is up.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c1a92c0a

drivers/net/phy/phy_device.c

+5 −1
Original line number Diff line number Diff line
@@ -1739,13 +1739,17 @@ EXPORT_SYMBOL(genphy_update_link); 
 */

int genphy_read_status(struct phy_device *phydev)

{

	int adv, lpa, lpagb, err;

	int adv, lpa, lpagb, err, old_link = phydev->link;



	/* Update the link, but return if there was an error */

	err = genphy_update_link(phydev);

	if (err)

		return err;



	/* why bother the PHY if nothing can have changed */

	if (phydev->autoneg == AUTONEG_ENABLE && old_link && phydev->link)

		return 0;



	phydev->speed = SPEED_UNKNOWN;

	phydev->duplex = DUPLEX_UNKNOWN;

	phydev->pause = 0;