Commit 88c12a02 authored Jan 29, 2019 by Gustavo A. R. Silva Committed by Daniel Vetter Jan 30, 2019

drm/via: mark expected switch fall-throughs



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warnings:

drivers/gpu/drm/via/via_dmablit.c:179:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/gpu/drm/via/via_dmablit.c:185:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/gpu/drm/via/via_dmablit.c:187:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/gpu/drm/via/via_dmablit.c:195:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190129201742.GA25660@embeddedor

parent 11ca1b66

drivers/gpu/drm/via/via_dmablit.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -177,12 +177,14 @@ via_free_sg_info(struct pci_dev pdev, drm_via_sg_info_t vsg)
		switch (vsg->state) {
		case dr_via_device_mapped:
		via_unmap_blit_from_device(pdev, vsg);
		/* fall through */
		case dr_via_desc_pages_alloc:
		for (i = 0; i < vsg->num_desc_pages; ++i) {
		if (vsg->desc_pages[i] != NULL)
		free_page((unsigned long)vsg->desc_pages[i]);
		}
		kfree(vsg->desc_pages);
		/* fall through */
		case dr_via_pages_locked:
		for (i = 0; i < vsg->num_pages; ++i) {
		if (NULL != (page = vsg->pages[i])) {
		@@ -191,8 +193,10 @@ via_free_sg_info(struct pci_dev pdev, drm_via_sg_info_t vsg)
		put_page(page);
		}
		}
		/* fall through */
		case dr_via_pages_alloc:
		vfree(vsg->pages);
		/* fall through */
		default:
		vsg->state = dr_via_sg_init;
		}