Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 889b9129 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Greg Kroah-Hartman
Browse files

i2c: qcom-geni: Use IRQF_NO_AUTOEN flag in request_irq() 



[ Upstream commit e2c85d85a05f16af2223fcc0195ff50a7938b372 ]

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.

Fixes: 37692de5 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller")
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Cc: <stable@vger.kernel.org> # v4.19+
Acked-by: default avatarMukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Reviewed-by: default avatarVladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 66b9e6e2

drivers/i2c/busses/i2c-qcom-geni.c

+1 −3
Original line number Diff line number Diff line
@@ -571,15 +571,13 @@ static int geni_i2c_probe(struct platform_device *pdev) 
	init_completion(&gi2c->done);

	spin_lock_init(&gi2c->lock);

	platform_set_drvdata(pdev, gi2c);

	ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, 0,

	ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN,

			       dev_name(dev), gi2c);

	if (ret) {

		dev_err(dev, "Request_irq failed:%d: err:%d\n",

			gi2c->irq, ret);

		return ret;

	}

	/* Disable the interrupt so that the system can enter low-power mode */

	disable_irq(gi2c->irq);

	i2c_set_adapdata(&gi2c->adap, gi2c);

	gi2c->adap.dev.parent = dev;

	gi2c->adap.dev.of_node = dev->of_node;