Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87ced2f9 authored by Wolfram Sang's avatar Wolfram Sang Committed by David S. Miller
Browse files

net: can: usb: ems_usb: don't print error when allocating urb fails 



kmalloc will print enough information in case of failure.

Signed-off-by: default avatarWolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6176e89c

drivers/net/can/usb/ems_usb.c

+2 −7
Original line number Original line Diff line number Diff line
@@ -600,7 +600,6 @@ static int ems_usb_start(struct ems_usb *dev) 
		/* create a URB, and a buffer for it */

		/* create a URB, and a buffer for it */

		urb = usb_alloc_urb(0, GFP_KERNEL);

		urb = usb_alloc_urb(0, GFP_KERNEL);

		if (!urb) {

		if (!urb) {

			netdev_err(netdev, "No memory left for URBs\n");

			err = -ENOMEM;

			err = -ENOMEM;

			break;

			break;

		}

		}
@@ -752,10 +751,8 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne 




	/* create a URB, and a buffer for it, and copy the data to the URB */

	/* create a URB, and a buffer for it, and copy the data to the URB */

	urb = usb_alloc_urb(0, GFP_ATOMIC);

	urb = usb_alloc_urb(0, GFP_ATOMIC);

	if (!urb) {

	if (!urb)

		netdev_err(netdev, "No memory left for URBs\n");

		goto nomem;

		goto nomem;

	}





	buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC, &urb->transfer_dma);

	buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC, &urb->transfer_dma);

	if (!buf) {

	if (!buf) {
@@ -1007,10 +1004,8 @@ static int ems_usb_probe(struct usb_interface *intf, 
		dev->tx_contexts[i].echo_index = MAX_TX_URBS;

		dev->tx_contexts[i].echo_index = MAX_TX_URBS;





	dev->intr_urb = usb_alloc_urb(0, GFP_KERNEL);

	dev->intr_urb = usb_alloc_urb(0, GFP_KERNEL);

	if (!dev->intr_urb) {

	if (!dev->intr_urb)

		dev_err(&intf->dev, "Couldn't alloc intr URB\n");

		goto cleanup_candev;

		goto cleanup_candev;

	}





	dev->intr_in_buffer = kzalloc(INTR_IN_BUFFER_SIZE, GFP_KERNEL);

	dev->intr_in_buffer = kzalloc(INTR_IN_BUFFER_SIZE, GFP_KERNEL);

	if (!dev->intr_in_buffer)

	if (!dev->intr_in_buffer)