Commit 87b1ee83 authored Sep 25, 2023 by Dinghao Liu Committed by Greg Kroah-Hartman Nov 20, 2023

mfd: dln2: Fix double put in dln2_probe



[ Upstream commit 759c409bc5fc496cbc22cd0b392d3cbb0c0e23eb ]

The dln2_free() already contains usb_put_dev(). Therefore,
the redundant usb_put_dev() before dln2_free() may lead to
a double free.

Fixes: 96da8f148396 ("mfd: dln2: Fix memory leak in dln2_probe()")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230925024134.9683-1-dinghao.liu@zju.edu.cn


Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent b843d2cd

drivers/mfd/dln2.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -797,7 +797,6 @@ static int dln2_probe(struct usb_interface *interface,
		dln2_stop_rx_urbs(dln2);

		out_free:
		usb_put_dev(dln2->usb_dev);
		dln2_free(dln2);

		return ret;