Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87b0984e authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

net: Add extack argument to ndo_fdb_add() 



Drivers may not be able to support certain FDB entries, and an error
code is insufficient to give clear hints as to the reasons of rejection.

In order to make it possible to communicate the rejection reason, extend
ndo_fdb_add() with an extack argument. Adapt the existing
implementations of ndo_fdb_add() to take the parameter (and ignore it).
Pass the extack parameter when invoking ndo_fdb_add() from rtnl_fdb_add().

Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1cdc98c2

drivers/net/ethernet/intel/i40e/i40e_main.c

+2 −1
Original line number Diff line number Diff line
@@ -11644,7 +11644,8 @@ static int i40e_get_phys_port_id(struct net_device *netdev, 
static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],

			    struct net_device *dev,

			    const unsigned char *addr, u16 vid,

			    u16 flags)

			    u16 flags,

			    struct netlink_ext_ack *extack)

{

	struct i40e_netdev_priv *np = netdev_priv(dev);

	struct i40e_pf *pf = np->vsi->back;

drivers/net/ethernet/intel/ice/ice_main.c

+2 −1
Original line number Diff line number Diff line
@@ -2438,7 +2438,8 @@ static void ice_set_rx_mode(struct net_device *netdev) 
 */

static int ice_fdb_add(struct ndmsg *ndm, struct nlattr __always_unused *tb[],

		       struct net_device *dev, const unsigned char *addr,

		       u16 vid, u16 flags)

		       u16 vid, u16 flags,

		       struct netlink_ext_ack *extack)

{

	int err;

drivers/net/ethernet/intel/igb/igb_main.c

+2 −1
Original line number Diff line number Diff line
@@ -2486,7 +2486,8 @@ static int igb_set_features(struct net_device *netdev, 
static int igb_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],

			   struct net_device *dev,

			   const unsigned char *addr, u16 vid,

			   u16 flags)

			   u16 flags,

			   struct netlink_ext_ack *extack)

{

	/* guarantee we can provide a unique filter for the unicast address */

	if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr)) {

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

+2 −1
Original line number Diff line number Diff line
@@ -9910,7 +9910,8 @@ static void ixgbe_del_udp_tunnel_port(struct net_device *dev, 
static int ixgbe_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],

			     struct net_device *dev,

			     const unsigned char *addr, u16 vid,

			     u16 flags)

			     u16 flags,

			     struct netlink_ext_ack *extack)

{

	/* guarantee we can provide a unique filter for the unicast address */

	if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr)) {

drivers/net/ethernet/mscc/ocelot.c

+2 −1
Original line number Diff line number Diff line
@@ -721,7 +721,8 @@ static void ocelot_get_stats64(struct net_device *dev, 


static int ocelot_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],

			  struct net_device *dev, const unsigned char *addr,

			  u16 vid, u16 flags)

			  u16 vid, u16 flags,

			  struct netlink_ext_ack *extack)

{

	struct ocelot_port *port = netdev_priv(dev);

	struct ocelot *ocelot = port->ocelot;