Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87affdde authored by Vasily Ulyanov's avatar Vasily Ulyanov Committed by Kalle Valo
Browse files

qtnfmac: fix warnings when mBSS setup is stopped 



Virtual interface should be deleted after calling unregister_netdevice
since this function ends up with sending updown_intf command to card.

Signed-off-by: default avatarVasily Ulyanov <vulyanov@quantenna.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 33f98992

drivers/net/wireless/quantenna/qtnfmac/cfg80211.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -120,10 +120,6 @@ int qtnf_del_virtual_intf(struct wiphy *wiphy, struct wireless_dev *wdev) 




	qtnf_scan_done(vif->mac, true);

	qtnf_scan_done(vif->mac, true);





	if (qtnf_cmd_send_del_intf(vif))

		pr_err("VIF%u.%u: failed to delete VIF\n", vif->mac->macid,

		       vif->vifid);



	/* Stop data */

	/* Stop data */

	netif_tx_stop_all_queues(netdev);

	netif_tx_stop_all_queues(netdev);

	if (netif_carrier_ok(netdev))

	if (netif_carrier_ok(netdev))
@@ -132,6 +128,10 @@ int qtnf_del_virtual_intf(struct wiphy *wiphy, struct wireless_dev *wdev) 
	if (netdev->reg_state == NETREG_REGISTERED)

	if (netdev->reg_state == NETREG_REGISTERED)

		unregister_netdevice(netdev);

		unregister_netdevice(netdev);





	if (qtnf_cmd_send_del_intf(vif))

		pr_err("VIF%u.%u: failed to delete VIF\n", vif->mac->macid,

		       vif->vifid);



	vif->netdev->ieee80211_ptr = NULL;

	vif->netdev->ieee80211_ptr = NULL;

	vif->netdev = NULL;

	vif->netdev = NULL;

	vif->wdev.iftype = NL80211_IFTYPE_UNSPECIFIED;

	vif->wdev.iftype = NL80211_IFTYPE_UNSPECIFIED;