Commit 878e7f39 authored Jun 20, 2022 by Hangyu Hua Committed by Greg Kroah-Hartman Aug 25, 2022

wifi: libertas: Fix possible refcount leak in if_usb_probe()



[ Upstream commit 6fd57e1d120bf13d4dc6c200a7cf914e6347a316 ]

usb_get_dev will be called before lbs_get_firmware_async which means that
usb_put_dev need to be called when lbs_get_firmware_async fails.

Fixes: ce84bb69 ("libertas USB: convert to asynchronous firmware loading")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220620092350.39960-1-hbh25y@gmail.com
Link: https://lore.kernel.org/r/20220622113402.16969-1-colin.i.king@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5cca5f71

drivers/net/wireless/marvell/libertas/if_usb.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -287,6 +287,7 @@ static int if_usb_probe(struct usb_interface *intf,
		return 0;

		err_get_fw:
		usb_put_dev(udev);
		lbs_remove_card(priv);
		err_add_card:
		if_usb_reset_device(cardp);