Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 876d716b authored by Doug Anderson's avatar Doug Anderson Committed by Heiko Stuebner
Browse files

pinctrl: rockchip: Set wake_enabled 



The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup
the .wake_enabled member.  That means that we can never actually use a
pin for wakeup.  When "irq_set_irq_wake()" tries to call through it
will always get a failure from set_irq_wake_real() and will then set
wake_depth to 0.  Assuming you can resume you'll later get an error
message about "Unbalanced IRQ x wake disable".

Signed-off-by: default avatarDoug Anderson <dianders@chromium.org>
Tested-by: default avatarChris Zhong <zyw@rock-chips.com>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent f114040e

drivers/pinctrl/pinctrl-rockchip.c

+1 −0
Original line number Diff line number Diff line
@@ -1563,6 +1563,7 @@ static int rockchip_interrupts_register(struct platform_device *pdev, 
		gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit;

		gc->chip_types[0].chip.irq_set_wake = irq_gc_set_wake;

		gc->chip_types[0].chip.irq_set_type = rockchip_irq_set_type;

		gc->wake_enabled = IRQ_MSK(bank->nr_pins);



		irq_set_handler_data(bank->irq, bank);

		irq_set_chained_handler(bank->irq, rockchip_irq_demux);