Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 871a1e94 authored by Xu Wang's avatar Xu Wang Committed by Greg Kroah-Hartman
Browse files

i2c: Fix a potential use after free 



[ Upstream commit e4c72c06c367758a14f227c847f9d623f1994ecf ]

Free the adap structure only after we are done using it.
This patch just moves the put_device() down a bit to avoid the
use after free.

Fixes: 611e12ea ("i2c: core: manage i2c bus device refcount in i2c_[get|put]_adapter")
Signed-off-by: default avatarXu Wang <vulab@iscas.ac.cn>
[wsa: added comment to the code, added Fixes tag]
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 127ecd6b

drivers/i2c/i2c-core-base.c

+2 −1
Original line number Diff line number Diff line
@@ -2358,8 +2358,9 @@ void i2c_put_adapter(struct i2c_adapter *adap) 
	if (!adap)

		return;



	put_device(&adap->dev);

	module_put(adap->owner);

	/* Should be last, otherwise we risk use-after-free with 'adap' */

	put_device(&adap->dev);

}

EXPORT_SYMBOL(i2c_put_adapter);