Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 87170d10 authored by Mukesh Kumar Savaliya's avatar Mukesh Kumar Savaliya Committed by Akash Asthana
Browse files

platform : msm-geni-se: fix voting unit for bus bandwidth 



Bandwidth vote values were being applied as Bytes-per-second but
the interconnect framework expects Kilobytes-per-second units. Fix
the error by using unit conversion macros provided by the
interconnect interface.

Change-Id: If2e921b7213e7f61459930b9739c6fa0c0257bf9
Signed-off-by: default avatarMukesh Kumar Savaliya <msavaliy@codeaurora.org>
Signed-off-by: default avatarAkash Asthana <akashast@codeaurora.org>
parent 207dad90

drivers/i2c/busses/i2c-msm-geni.c

+0 −1
Original line number Diff line number Diff line
@@ -50,7 +50,6 @@ 
#define SLV_ADDR_SHFT		(9)



#define I2C_PACK_EN		(BIT(0) | BIT(1))

#define I2C_CORE2X_VOTE		(960)

#define GP_IRQ0			0

#define GP_IRQ1			1

#define GP_IRQ2			2

drivers/i3c/master/i3c-master-msm-geni.c

+0 −3
Original line number Diff line number Diff line
@@ -189,9 +189,6 @@ enum geni_i3c_err_code { 
#define PACKING_BYTES_PW	4

#define XFER_TIMEOUT		HZ

#define DFS_INDEX_MAX		7

#define I3C_CORE2X_VOTE		(960)

#define DEFAULT_BUS_WIDTH	(4)

#define DEFAULT_SE_CLK		(19200000)



#define I3C_DDR_READ_CMD BIT(7)

#define I3C_ADDR_MASK	0x7f

drivers/platform/msm/msm-geni-se.c

+1 −2
Original line number Diff line number Diff line
@@ -29,8 +29,7 @@ 
#define GENI_SE_DMA_PTR_H(ptr) 0

#endif



/* Convert BCM threshold to actual frequency x 4 */

#define CONV_TO_BW(x) (x*20000*4)

#define CONV_TO_BW(x) (x*4)

#define NUM_LOG_PAGES 2

#define MAX_CLK_PERF_LEVEL 32

static unsigned long default_bus_bw_set[] = {0, 19200000, 50000000,

drivers/spi/spi-msm-geni.c

+1 −2
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.

 * Copyright (c) 2017-2020, The Linux Foundation. All rights reserved.

 */
@@ -83,7 +83,6 @@ 
#define TIMESTAMP_AFTER		BIT(3)

#define POST_CMD_DELAY		BIT(4)



#define SPI_CORE2X_VOTE		(5000)

/* GSI CONFIG0 TRE Params */

/* Flags bit fields */

#define GSI_LOOPBACK_EN		(BIT(0))

drivers/tty/serial/msm_geni_serial.c

+0 −2
Original line number Diff line number Diff line
@@ -106,8 +106,6 @@ 
#define DEF_FIFO_DEPTH_WORDS	(16)

#define DEF_TX_WM		(2)

#define DEF_FIFO_WIDTH_BITS	(32)

#define UART_CORE2X_VOTE	(5000)

#define UART_CONSOLE_CORE2X_VOTE (960)



#define WAKEBYTE_TIMEOUT_MSEC	(2000)

#define WAIT_XFER_MAX_ITER	(2)