Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 871641c7 authored by Pawel Witek's avatar Pawel Witek Committed by Greg Kroah-Hartman
Browse files

cifs: fix pcchunk length type in smb2_copychunk_range 



commit d66cde50c3c868af7abddafce701bb86e4a93039 upstream.

Change type of pcchunk->Length from u32 to u64 to match
smb2_copychunk_range arguments type. Fixes the problem where performing
server-side copy with CIFS_IOC_COPYCHUNK_FILE ioctl resulted in incomplete
copy of large files while returning -EINVAL.

Fixes: 9bf0c9cd ("CIFS: Fix SMB2/SMB3 Copy offload support (refcopy) for large files")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarPawel Witek <pawel.ireneusz.witek@gmail.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3e2b4bce

fs/cifs/smb2ops.c

+1 −1
Original line number Diff line number Diff line
@@ -1678,7 +1678,7 @@ smb2_copychunk_range(const unsigned int xid, 
		pcchunk->SourceOffset = cpu_to_le64(src_off);

		pcchunk->TargetOffset = cpu_to_le64(dest_off);

		pcchunk->Length =

			cpu_to_le32(min_t(u32, len, tcon->max_bytes_chunk));

			cpu_to_le32(min_t(u64, len, tcon->max_bytes_chunk));



		/* Request server copy to target from src identified by key */

		kfree(retbuf);