Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86eca4e7 authored by Olivier Guiter's avatar Olivier Guiter Committed by Samuel Ortiz
Browse files

NFC: pn533: Fix ACR122 related debug output 



Instead of dumping ACR122 frames as errors, we use the print_hex_dump()
dynamic debug APIs.
We also print an accurate IC version, as the ACR122 is pn532 based.

Signed-off-by: default avatarOlivier Guiter <olivier.guiter@linux.intel.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent be085653

drivers/nfc/pn533.c

+4 −4
Original line number Diff line number Diff line
@@ -2501,7 +2501,7 @@ static void pn533_acr122_poweron_rdr_resp(struct urb *urb) 


	nfc_dev_dbg(&urb->dev->dev, "%s", __func__);



	print_hex_dump(KERN_ERR, "ACR122 RX: ", DUMP_PREFIX_NONE, 16, 1,

	print_hex_dump_debug("ACR122 RX: ", DUMP_PREFIX_NONE, 16, 1,

		       urb->transfer_buffer, urb->transfer_buffer_length,

		       false);
@@ -2532,7 +2532,7 @@ static int pn533_acr122_poweron_rdr(struct pn533 *dev) 
	dev->out_urb->transfer_buffer = cmd;

	dev->out_urb->transfer_buffer_length = sizeof(cmd);



	print_hex_dump(KERN_ERR, "ACR122 TX: ", DUMP_PREFIX_NONE, 16, 1,

	print_hex_dump_debug("ACR122 TX: ", DUMP_PREFIX_NONE, 16, 1,

		       cmd, sizeof(cmd), false);



	rc = usb_submit_urb(dev->out_urb, GFP_KERNEL);
@@ -2786,8 +2786,8 @@ static int pn533_probe(struct usb_interface *interface, 
		goto destroy_wq;



	nfc_dev_info(&dev->interface->dev,

		     "NXP PN533 firmware ver %d.%d now attached",

		     fw_ver.ver, fw_ver.rev);

		     "NXP PN5%02X firmware ver %d.%d now attached",

		     fw_ver.ic, fw_ver.ver, fw_ver.rev);





	dev->nfc_dev = nfc_allocate_device(&pn533_nfc_ops, protocols,