Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86d19a54 authored by Hongbo Zhang's avatar Hongbo Zhang Committed by Vinod Koul
Browse files

DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication 



There are several places where descriptors are freed using identical code.
This patch puts this code into a function to reduce code duplication.

Signed-off-by: default avatarHongbo Zhang <hongbo.zhang@freescale.com>
Signed-off-by: default avatarQiang Liu <qiang.liu@freescale.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 867dfa5d

drivers/dma/fsldma.c

+17 −10
Original line number Diff line number Diff line
@@ -417,6 +417,19 @@ static dma_cookie_t fsl_dma_tx_submit(struct dma_async_tx_descriptor *tx) 
	return cookie;

}



/**

 * fsl_dma_free_descriptor - Free descriptor from channel's DMA pool.

 * @chan : Freescale DMA channel

 * @desc: descriptor to be freed

 */

static void fsl_dma_free_descriptor(struct fsldma_chan *chan,

		struct fsl_desc_sw *desc)

{

	list_del(&desc->node);

	chan_dbg(chan, "LD %p free\n", desc);

	dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys);

}



/**

 * fsl_dma_alloc_descriptor - Allocate descriptor from channel's DMA pool.

 * @chan : Freescale DMA channel
@@ -489,11 +502,8 @@ static void fsldma_free_desc_list(struct fsldma_chan *chan, 
{

	struct fsl_desc_sw *desc, *_desc;



	list_for_each_entry_safe(desc, _desc, list, node) {

		list_del(&desc->node);

		chan_dbg(chan, "LD %p free\n", desc);

		dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys);

	}

	list_for_each_entry_safe(desc, _desc, list, node)

		fsl_dma_free_descriptor(chan, desc);

}



static void fsldma_free_desc_list_reverse(struct fsldma_chan *chan,
@@ -501,11 +511,8 @@ static void fsldma_free_desc_list_reverse(struct fsldma_chan *chan, 
{

	struct fsl_desc_sw *desc, *_desc;



	list_for_each_entry_safe_reverse(desc, _desc, list, node) {

		list_del(&desc->node);

		chan_dbg(chan, "LD %p free\n", desc);

		dma_pool_free(chan->desc_pool, desc, desc->async_tx.phys);

	}

	list_for_each_entry_safe_reverse(desc, _desc, list, node)

		fsl_dma_free_descriptor(chan, desc);

}



/**