Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86cccfbf authored by Anton Eidelman's avatar Anton Eidelman Committed by Jens Axboe
Browse files

nvme-multipath: remove unused groups_only mode in ana log 



groups_only mode in nvme_read_ana_log() is no longer used: remove it.

Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarAnton Eidelman <anton@lightbitslabs.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent af8fd042

drivers/nvme/host/multipath.c

+4 −5
Original line number Diff line number Diff line
@@ -522,14 +522,13 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl, 
	return 0;

}



static int nvme_read_ana_log(struct nvme_ctrl *ctrl, bool groups_only)

static int nvme_read_ana_log(struct nvme_ctrl *ctrl)

{

	u32 nr_change_groups = 0;

	int error;



	mutex_lock(&ctrl->ana_lock);

	error = nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_ANA,

			groups_only ? NVME_ANA_LOG_RGO : 0,

	error = nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_ANA, 0,

			ctrl->ana_log_buf, ctrl->ana_log_size, 0);

	if (error) {

		dev_warn(ctrl->device, "Failed to get ANA log: %d\n", error);
@@ -565,7 +564,7 @@ static void nvme_ana_work(struct work_struct *work) 
{

	struct nvme_ctrl *ctrl = container_of(work, struct nvme_ctrl, ana_work);



	nvme_read_ana_log(ctrl, false);

	nvme_read_ana_log(ctrl);

}



static void nvme_anatt_timeout(struct timer_list *t)
@@ -715,7 +714,7 @@ int nvme_mpath_init(struct nvme_ctrl *ctrl, struct nvme_id_ctrl *id) 
		goto out;

	}



	error = nvme_read_ana_log(ctrl, false);

	error = nvme_read_ana_log(ctrl);

	if (error)

		goto out_free_ana_log_buf;

	return 0;