Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 869817f9 authored Jan 28, 2016 by Suganath prabu Subramani Committed by Martin K. Petersen Feb 23, 2016

mpt3sas: Fix static analyzer(coverity) tool identified defects



1.Wrong size of argument is being passed
 The size of struct being passed as an argument to memset func and area of
 memory being pointed by an instance of struct in memset func should be of
 same structure type.
2.Dereference null return value
3.Array compared against '0'
 Check whether value pointed by particular index of an array is null or not
 in "if" statement.

Signed-off-by: Suganath prabu Subramani <suganath-prabu.subramani@avagotech.com>
Signed-off-by: Chaitra P B <chaitra.basappa@avagotech.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ce61c574

drivers/scsi/mpt3sas/mpt3sas_ctl.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -401,6 +401,7 @@ mpt3sas_ctl_event_callback(struct MPT3SAS_ADAPTER *ioc, u8 msix_index,
		Mpi2EventNotificationReply_t *mpi_reply;

		mpi_reply = mpt3sas_base_get_reply_virt_addr(ioc, reply);
		if (mpi_reply)
		mpt3sas_ctl_add_to_event_log(ioc, mpi_reply);
		return 1;
		}

drivers/scsi/mpt3sas/mpt3sas_scsih.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2399,7 +2399,7 @@ _scsih_tm_display_info(struct MPT3SAS_ADAPTER ioc, struct scsi_cmnd scmd)
		(unsigned long long)
		sas_device->enclosure_logical_id,
		sas_device->slot);
		if (sas_device->connector_name)
		if (sas_device->connector_name[0] != '\0')
		starget_printk(KERN_INFO, starget,
		"enclosure level(0x%04x),connector name(%s)\n",
		sas_device->enclosure_level,
		@@ -3134,7 +3134,7 @@ _scsih_tm_tr_send(struct MPT3SAS_ADAPTER *ioc, u16 handle)
		" slot(%d)\n", ioc->name, (unsigned long long)
		sas_device->enclosure_logical_id,
		sas_device->slot));
		if (sas_device->connector_name)
		if (sas_device->connector_name[0] != '\0')
		dewtprintk(ioc, pr_info(MPT3SAS_FMT
		"setting delete flag: enclosure level(0x%04x),"
		" connector name( %s)\n", ioc->name,

drivers/scsi/mpt3sas/mpt3sas_transport.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1600,7 +1600,7 @@ _transport_phy_reset(struct sas_phy *phy, int hard_reset)
		SMP_PHY_CONTROL_LINK_RESET);

		/* handle hba phys */
		memset(&mpi_request, 0, sizeof(Mpi2SasIoUnitControlReply_t));
		memset(&mpi_request, 0, sizeof(Mpi2SasIoUnitControlRequest_t));
		mpi_request.Function = MPI2_FUNCTION_SAS_IO_UNIT_CONTROL;
		mpi_request.Operation = hard_reset ?
		MPI2_SAS_OP_PHY_HARD_RESET : MPI2_SAS_OP_PHY_LINK_RESET;