Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86954a52 authored by Trond Myklebust's avatar Trond Myklebust Committed by Greg Kroah-Hartman
Browse files

NFS: Don't gratuitously clear the inode cache when lookup failed 



[ Upstream commit 47397915ede0192235474b145ebcd81b37b03624 ]

The fact that the lookup revalidation failed, does not mean that the
inode contents have changed.

Fixes: 5ceb9d7f ("NFS: Refactor nfs_lookup_revalidate()")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d29f9aa6

fs/nfs/dir.c

+8 −12
Original line number Diff line number Diff line
@@ -1116,18 +1116,14 @@ nfs_lookup_revalidate_done(struct inode *dir, struct dentry *dentry, 
			__func__, dentry);

		return 1;

	case 0:

		if (inode && S_ISDIR(inode->i_mode)) {

			/* Purge readdir caches. */

			nfs_zap_caches(inode);

		/*

		 * We can't d_drop the root of a disconnected tree:

		 * its d_hash is on the s_anon list and d_drop() would hide

		 * it from shrink_dcache_for_unmount(), leading to busy

		 * inodes on unmount and further oopses.

		 */

			if (IS_ROOT(dentry))

		if (inode && IS_ROOT(dentry))

			return 1;

		}

		dfprintk(LOOKUPCACHE, "NFS: %s(%pd2) is invalid\n",

				__func__, dentry);

		return 0;