Commit 866e6ac4 authored Jan 24, 2019 by Prashant Bhole Committed by Daniel Borkmann Jan 24, 2019

bpftool: feature probing, change default action



When 'bpftool feature' is executed it shows incorrect help string.

test# bpftool feature
Usage: bpftool bpftool probe [COMPONENT] [macros [prefix PREFIX]]
       bpftool bpftool help

       COMPONENT := { kernel | dev NAME }

Instead of fixing the help text by tweaking argv[] indices, this
patch changes the default action to 'probe'. It makes the behavior
consistent with other subcommands, where first subcommand without
extra parameter results in 'show' action.

Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 923cefe3

tools/bpf/bpftool/feature.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -753,8 +753,8 @@ static int do_help(int argc, char **argv)
		}

		static const struct cmd cmds[] = {
		{ "help", do_help },
		{ "probe", do_probe },
		{ "help", do_help },
		{ 0 }
		};